aaron.ballman added a comment. In D73457#1844475 <https://reviews.llvm.org/D73457#1844475>, @thakis wrote:
> Since we auto-detect -fmsc-version if it's not explicitly installed and since > this warning is on by default, it makes the test suite depend on the > environment a good bit. Given how old 2015 is by now, I'm not sure this > complexity and subtlety is worth the benefit? I think it's worth the benefit -- the point to the check is to help catch buffer overflows, and getting the length calculation correct for that is important. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73457/new/ https://reviews.llvm.org/D73457 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
