kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:887
+ public:
+ $1^operator int();
+ };
----------------
could you rather have a conversion operator to a tag (like `struct Bar`), with
a fixme of course mentionining the issue you have in clangd bug tracker(not a
link but rather a short description)
================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:905
+ public:
+ ~$1^Foo() {}
+
----------------
this actually looks troublesome, since we are not returning the functiondecl
anymore(also for references to it as well), even though it is explicitly
spelled in the source code.
I suppose it is OK to keep that behavior for now, as there are no callers
caring about those typednames yet.
just thinking out loud:
In case we start to have such clients, it might be more principled to report
`$1~$2Foo` in here(I know it is the old behavior :/ ) and handle those
differently in the callers' with
custom needs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72638/new/
https://reviews.llvm.org/D72638
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
