kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:882
"10: targets = {ns}\n"},
+ // CXX Constructor, destructor and operators.
+ {R"cpp(
----------------
hokein wrote:
> could we simplify the newly-added test? I think a test only for explicit
> destructor calls is sufficient, I think.
>
> ```
> void foo () {
> class Foo { ~Foo(); };
> Foo f;
> f.~Foo();
> }
> ```
Simplified the test a bit. I don't think it hurts to have more coverage though
(if this is not duplication).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72638/new/
https://reviews.llvm.org/D72638
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
