akhuang marked 5 inline comments as done.
akhuang added inline comments.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516
void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init)
{
- assert(DebugKind >= codegenoptions::LimitedDebugInfo);
+ assert(CGM.getCodeGenOpts().isFullDebug());
if (VD->hasAttr<NoDebugAttr>())
----------------
aprantl wrote:
> akhuang wrote:
> > aprantl wrote:
> > > This change appears to be unnecessary?
> > Do you mean changing the DebugKind comparison?
> Yes, since the new kind is < Limited.
The new kind is supposed to do most of the same things as Limited, except
slightly more limited, so I think the comparison needs to be changed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72427/new/
https://reviews.llvm.org/D72427
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
