dblaikie added a comment.

What's the plan for this? Is it still in an experimental stage, with the intent 
to investigate the types that are no longer emitted unedr the flag & explain 
why they're missing (& either have a justification for why that's acceptable, 
or work on additional heuristics to address the gaps?)?

If so, I'd probably rather this not be a full driver flag - if it's a reliable 
way to reduce debug info size (like the existing heuristics under 
-fstandalone-debug*) it should be rolled into -fno-standalone-debug behavior, 
and if it's not fully fleshed out yet, I think an -Xclang flag would be more 
suitable for the experimental phase.

Do you have any sample of data on the sort of situations that lead to missing 
types under this heuristic?

- that's also another point, the -flimit-debug-info is sort of the "old" name, 
there was a bit of a lengthy discussion about what to support and how to 
support it and eventually settled on the "-fstandalone-debug" flag name to 
represent the design goal here: debug info emitted under the assumption that no 
other files have debug info, or that all other files have debug info. So by 
that approach, this new behavior seems to fit under the "-fno-standalone-debug" 
behavior, without a new flag, if it's a reliable heuristic - but I understand 
it may be helpful to iterate in-tree on the specific edge cases, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72427/new/

https://reviews.llvm.org/D72427



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to