kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, LGTM! ================ Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1093 + + // If the main file is in the index, we don't return duplicates. + // (even if the references are in a different location) ---------------- i know the comment is copied over, but it doesn't reflect what's going on. as this check makes sure we prever results from AST rather than index for main file, not the duplicate handling(which actually de-dups references on the *same* location). since this is handled in the common code path, it is OK to check only in one of the tests(up to you though). but please update the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72395/new/ https://reviews.llvm.org/D72395 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
