sylvestre.ledru added inline comments.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:198
cppcoreguidelines-avoid-magic-numbers (redirects to
readability-magic-numbers) <cppcoreguidelines-avoid-magic-numbers>
+ cppcoreguidelines-avoid-non-const-global-variables
cppcoreguidelines-c-copy-assignment-signature (redirects to
misc-unconventional-assign-operator)
<cppcoreguidelines-c-copy-assignment-signature>
----------------
aaron.ballman wrote:
> vingeldal wrote:
> > sylvestre.ledru wrote:
> > > list.rst changed, you should update this!
> > > Thanks
> > >
> > I'm a bit concerned with this previous change of of list.rst.
> >
> > Now that I need to add a check to this file, I don't know what severity to
> > give it. I can't find any definition of severity levels and I really want
> > to avoid getting into a long discussion, or having different reviewers not
> > agreeing on my patch, concerning what severity we should give this check.
> > Is there any way I can find some kind of guideline on how to set the
> > severity to avoid an opinionated discussion about severity level?
> I'd like to follow that discussion so that I can be consistent with my review
> advice, too.
Good point!
I propose this patch to explain
https://reviews.llvm.org/D71963
this is a lazy copy and paste of
https://github.com/Ericsson/codechecker/blob/master/config/config.md
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70265/new/
https://reviews.llvm.org/D70265
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
