vingeldal marked an inline comment as done. vingeldal added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:123-124 + "member variable %0 provides global access to non-const type, " + "consider " + "making the referenced data const") + << MemberReference; // FIXME: Add fix-it hint to MemberReference ---------------- aaron.ballman wrote: > vingeldal wrote: > > aaron.ballman wrote: > > > Can re-flow this string literal. > > Sorry, I don't understand what you mean by re-flow. > Sorry for not being clear -- the string literal spans three lines when it > only needs to span two by re-writing the literal. e.g., > ``` > "member variable %0 provides global access to non-const type, " > "consider making the pointed-to data const" > ``` Ah, yes that's looks better of course. Will fix that in coming update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70265/new/ https://reviews.llvm.org/D70265 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
