aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from some nits. Thank you for this! ================ Comment at: clang/test/AST/gen_ast_dump_json_test.py:3 +from __future__ import print_function from collections import OrderedDict ---------------- Is this needed? I don't see anything using `print_function`. ================ Comment at: clang/test/AST/gen_ast_dump_json_test.py:11 import re +import tempfile import subprocess ---------------- Can you keep this in alphabetical order? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70119/new/ https://reviews.llvm.org/D70119 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
