arichardson marked 2 inline comments as done. arichardson added inline comments.
================ Comment at: clang/test/AST/gen_ast_dump_json_test.py:3 +from __future__ import print_function from collections import OrderedDict ---------------- aaron.ballman wrote: > Is this needed? I don't see anything using `print_function`. Thanks for reviewing! Despite the mismatched name, all python 3 print features depend on this. For example the `sep=` and function like syntax. Python2 prints a tuple for paren expressions instead of treating print as a function. ================ Comment at: clang/test/AST/gen_ast_dump_json_test.py:11 import re +import tempfile import subprocess ---------------- aaron.ballman wrote: > Can you keep this in alphabetical order? Will fix before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70119/new/ https://reviews.llvm.org/D70119 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
