Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land.
In D69962#1741503 <https://reviews.llvm.org/D69962#1741503>, @NoQ wrote: > In D69962#1739440 <https://reviews.llvm.org/D69962#1739440>, @NoQ wrote: > > > In D69962#1738618 <https://reviews.llvm.org/D69962#1738618>, @Szelethus > > wrote: > > > > > Nice catch! Though, wouldn't the memory sanitizer buildbots break on this > > > reliably? > > > > > > I kinda hope so; i'll take a look at home. > > > Memory sanitizer at home: //*fails with 1700 uninitialized reads in > TableGen*//. Try to add a non-sanitizer built tablegen: `-DCLANG_TABLEGEN=/path/to/non/sanitized/clang-tblgen` `-DLLVM_TABLEGEN=/path/to/non/sanitized/llvm-tblgen` > I guess i could commit test first, then get buildbots to fail, then if they > do commit the code, otherwise commit the code and multiply the run-lines. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69962/new/ https://reviews.llvm.org/D69962 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
