hans added a comment. In D69760#1734534 <https://reviews.llvm.org/D69760#1734534>, @thakis wrote:
> In D69760#1734524 <https://reviews.llvm.org/D69760#1734524>, @thakis wrote: > > > We currently do cross builds of chrome/win on linux, and this breaks that. > > > > As far as I know, no linker other than lld-link is able to write PDB files, > > so when targeting windows-msvc we definitely shouldn't change the current > > behavior. I don't have an opinion on windows-mingw. > > > Actually, we don't call the linker through the compiler driver when targeting > Windows, so this doesn't break our cross build. I manually use `clang-cl > -fuse-ld=lld` often though, so it'd make me type a lot more :) IIUC, with Martin and Reid's suggestion to key this off the driver mode rather than the triple, "clang-cl -fuse-ld=lld" would still work though? I like that approach as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69760/new/ https://reviews.llvm.org/D69760 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
