plotfi marked 3 inline comments as done.
plotfi added a comment.
In D63978#1701864 <https://reviews.llvm.org/D63978#1701864>, @tamur wrote:
> It seems that with this patch, llvm-ifs starts to depend on yaml2obj, which
> as far as I know, was only used for testing purposes until now. Is this
> intended?
No not with this patch, but with an earlier patch llvm-ifs does use yaml to
generate elf. The library was available and elfabi wasn’t. I can move llvm-ifs
to elfabi when it is ready.
================
Comment at: clang/lib/Driver/Driver.cpp:3372
+ if (Phase == phases::IfsMerge) {
+ assert(Phase == PL.back() && "merging must be final compilation
step.");
+ MergerInputs.push_back(Current);
----------------
compnerd wrote:
> plotfi wrote:
> > compnerd wrote:
> > > Does the interface merging have to be the last step? I could see
> > > interface merging preceding linking just fine.
> > For now I think that's the expedient thing to do. Do you want to change
> > that?
> Add a TODO perhaps?
I agree with that.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63978/new/
https://reviews.llvm.org/D63978
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
