compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Driver/Driver.cpp:3372
+ if (Phase == phases::IfsMerge) {
+ assert(Phase == PL.back() && "merging must be final compilation
step.");
+ MergerInputs.push_back(Current);
----------------
plotfi wrote:
> compnerd wrote:
> > Does the interface merging have to be the last step? I could see interface
> > merging preceding linking just fine.
> For now I think that's the expedient thing to do. Do you want to change that?
Add a TODO perhaps?
================
Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.h:14
+#include "clang/Driver/ToolChain.h"
+#include <set>
+
----------------
cishida wrote:
> is this used anywhere?
Please remove the `using namespace` directive in the header.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63978/new/
https://reviews.llvm.org/D63978
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
