shafik added inline comments.
================ Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:151 +}; + +template <typename TypeParam, ASTImporter::ODRHandlingType ODRHandlingParam> ---------------- martong wrote: > balazske wrote: > > `FunctionTemplate` and `FunctionTemplateSpec` are missing? > Yes, because `FunctionTemplates` overload with each other. So they are > imported always "liberally". > > There is no point to liberally import conflicting > `FunctionTemplateSpecializations`. > The only thing we can do in that case is to omit the conflicting declaration. > And this is true in case of `ClassTemplateSpecialization`s too. > > Perhaps we should remove `struct ClassTemplateSpec` as well from here (?). > Because they are never going to be handled "liberally". > > @shafik , what do you think about this? What you say about `FunctionTemplateSpecializations` and `ClassTemplateSpecializations` seems to make sense, importing them liberally would require more than work in the importer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
