saugustine added a comment.

Thanks for the quick review. Assuming my response to your comment on line 138 
is adequate, would you mind checking it in?


================
Comment at: unittests/Tooling/QualTypeNamesTest.cpp:138
@@ -136,3 +137,3 @@
       "  typedef int non_dependent_type;\n"
       "  dependent_type dependent_type_var;\n"
       "  non_dependent_type non_dependent_type_var;\n"
----------------
rnk wrote:
> What's supposed to be printed for dependent_type_var?
I'm not clever enough to generate one that compiles when it is at the end of 
the TU.

When not at the end of the TU, this prints: FOO<X>::dependent_type, omitting 
the keyword.

I don't think this is worth adding as a test-case.



http://reviews.llvm.org/D17214



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to