rnk added a subscriber: rnk.
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
This code seems like it's intended to avoid operating on dependent types, so it
shouldn't need the template keyword. It's hard to have a fully qualified name
that's valid at global scope and still somehow mentions template parameters.
================
Comment at: unittests/Tooling/QualTypeNamesTest.cpp:138
@@ -136,3 +137,3 @@
" typedef int non_dependent_type;\n"
" dependent_type dependent_type_var;\n"
" non_dependent_type non_dependent_type_var;\n"
----------------
What's supposed to be printed for dependent_type_var?
http://reviews.llvm.org/D17214
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
