aaron.ballman added a comment. In D66397#1652771 <https://reviews.llvm.org/D66397#1652771>, @xbolva00 wrote:
> >> tbh, I would appreciate if you would leave the definition of > >> diagnoseXorMisusedAsPow() where it is and add a forward declare of the > >> function earlier in the file. > > I uploaded the patch almost 2 weeks ago and nobody complained so I thought it > is okay. Uploaded, fixed. I appreciate it -- this made it much easier to spot the actual changes in the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
