xbolva00 added a subscriber: regehr. xbolva00 added a comment. >> I now agree that it makes sense to warn when the operands are macros or >> variables.
I could re-add macro support and then @jfb or @regehr would blame this diagnostic because of macro support =] variables could open a new box of false positives. Anyway, your motivating case: >> minval -= 10 ^ -precision; // >> https://codesearch.isocpp.org/actcd19/main/q/qgis/qgis_2.18.28+dfsg-2/src/gui/editorwidgets/qgsrangewidgetwrapper.cpp This should be diagnosted. Location of "-" is not a macro. >> real_loop += (((unsigned int) *argv[4]+k) - 48) * 10^(strlen(argv[4]) - >> (k+1)); Too complex, no chance to diagnose it here :) Not related to macros. >> intermediate = (str[offset] - '0') / (10 ^ lpc); // >> https://codesearch.isocpp.org/actcd19/main/p/pacemaker/pacemaker_1.1.18-2/lib/common/iso8601.c lpc is not a macro, it is just loop int variable. Not related to macros. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
