NoQ added a comment.
Something went wrong with message generation, can you take a look?
================
Comment at: clang/test/Analysis/cast-value-notes.cpp:24
+ const auto &C = dyn_cast<Circle>(S);
+ // expected-note@-1 {{Assuming 'S' is a 'Circle', not a 'Shape'}}
+ // expected-note@-2 {{Dereference of null pointer}}
----------------
A circle is always a shape.
`Assuming 'S' is a 'Shape' that is not a 'Circle'` sounds about right.
Or just `Assuming 'S' is not a 'Circle'`.
================
Comment at: clang/test/Analysis/cast-value-notes.cpp:34
+ if (dyn_cast_or_null<Circle>(C)) {
+ // no-note: 'Assuming 'C' is a 'Circle', not a 'Circle''
+ return;
----------------
A circle is always a circle.
================
Comment at: clang/test/Analysis/cast-value-notes.cpp:55
+ if (dyn_cast_or_null<Triangle>(C)) {
+ // expected-note@-1 {{Assuming 'C' is a 'Triangle', not a 'Circle'}}
+ // expected-note@-2 {{Taking false branch}}
----------------
The `not a 'Circle'` part is suspiciously specific.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66325/new/
https://reviews.llvm.org/D66325
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
