NoQ added a comment. Yay! I understand the rough idea and it looks perfectly reasonable to start with. Please add FIXMEs/TODOs on how we eventually want to support more complicated inheritance hierarchies.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h:32 +/// A set of dynamic cast informations. +REGISTER_SET_WITH_PROGRAMSTATE(DynamicCastSet, clang::ento::DynamicCastInfo) ---------------- Emm, so you're saving successes and failures of all casts //regardless of which object is getting casted//? That's definitely not sufficient. If `X` is a `Stmt` that isn't an `Expr`, you can't automatically infer that `Y` is a `Stmt` that isn't an `Expr` for any object `Y` other than `X` . This information needs to be per-object. Then you'll need to clean it up in `checkDeadSymbols`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
