jvikstrom marked an inline comment as done.
jvikstrom added inline comments.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:56
+ if (isa<CXXConversionDecl>(MD))
+ // If the member is a conversion operator the loc will be invalid. This
+ // causes the addToken function to emit a lot of error logs about trying
----------------
hokein wrote:
> Maybe just `The MemberLoc is invalid for C++ conversion operato , we don't
> attempt to add a token for an invalid location`?
>
>
> Does the location is always invalid? or just for builtin types? e.g.
> ```
> class Foo {};
> struct Bar {
> explicit operator Foo*() const; // 1
> explicit operator int() const; // 2
> };
> ```
Builtin types has nothing to do with it. It's invalid for every conversion
operator. Will actually add a test just to make sure that everything else is
still highlighted correctly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65928/new/
https://reviews.llvm.org/D65928
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
