hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:56
+ if (isa<CXXConversionDecl>(MD))
+ // If the member is a conversion operator the loc will be invalid. This
+ // causes the addToken function to emit a lot of error logs about trying
----------------
Maybe just `The MemberLoc is invalid for C++ conversion operato , we don't
attempt to add a token for an invalid location`?
Does the location is always invalid? or just for builtin types? e.g.
```
class Foo {};
struct Bar {
explicit operator Foo*() const; // 1
explicit operator int() const; // 2
};
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65928/new/
https://reviews.llvm.org/D65928
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
