martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM, though I have some comments.
================
Comment at: clang/test/Analysis/Inputs/ctu-other.cpp:135
+
+struct DefParmContext {
+ static const int I;
----------------
Perhaps we could write `Default` instead of `Def`.
================
Comment at: clang/test/Analysis/Inputs/ctu-other.cpp:144
+
+int testDefParmIncompleteImport(int I) {
+ return fDefParm(I);
----------------
`testImportOfIncompleteDefaultParm` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65577/new/
https://reviews.llvm.org/D65577
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
