jkorous added a comment. Hi @hokein, Do you have any thoughts on how to handle situation when client registers callback but doesn't send a request with registered ID later?
================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:317 + std::lock_guard<std::mutex> Lock(ReplyCallbacksMutex); + ReplyCallbacks[StrID] = std::move(CB); + } ---------------- Should we care if there's already another callback registered for this `StrID`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65387/new/ https://reviews.llvm.org/D65387 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
