On Tue, Feb 9, 2016 at 12:07 PM, David Li via llvm-commits < llvm-comm...@lists.llvm.org> wrote:
> This revision was automatically updated to reflect the committed changes. > Closed by commit rL260270: [PGO] Fix issue: explicitly defaulted assignop > is not profiled (authored by davidxl). > In general, if you send something out for review it's best to wait for explicit sign-off before committing. Sorry I hadn't taken a moment to look at the clang test you had added - again, got a bit lost in the noise of the discussion. > > Changed prior to commit: > http://reviews.llvm.org/D16947?vs=47239&id=47351#toc > > Repository: > rL LLVM > > http://reviews.llvm.org/D16947 > > Files: > cfe/trunk/lib/CodeGen/CGClass.cpp > cfe/trunk/test/Profile/def-assignop.cpp > > Index: cfe/trunk/test/Profile/def-assignop.cpp > =================================================================== > --- cfe/trunk/test/Profile/def-assignop.cpp > +++ cfe/trunk/test/Profile/def-assignop.cpp > @@ -0,0 +1,32 @@ > +// RUN: %clang_cc1 -x c++ -std=c++11 %s -triple x86_64-unknown-linux-gnu > -main-file-name def-assignop.cpp -o - -emit-llvm -fprofile-instrument=clang > | FileCheck --check-prefix=PGOGEN %s > +// RUN: %clang_cc1 -x c++ -std=c++11 %s -triple x86_64-unknown-linux-gnu > -main-file-name def-assignop.cpp -o - -emit-llvm -fprofile-instrument=clang > -fcoverage-mapping | FileCheck --check-prefix=COVMAP %s > + > +struct B { > + B& operator=(const B &b); > + B& operator=(const B &&b); > +}; > + > +struct A { > + A &operator=(const A &) = default; > + // PGOGEN: define {{.*}}@_ZN1AaSERKS_( > + // PGOGEN: %pgocount = load {{.*}} @__profc__ZN1AaSERKS_ > + // PGOGEN: {{.*}}add{{.*}}%pgocount, 1 > + // PGOGEN: store{{.*}}@__profc__ZN1AaSERKS_ > + A &operator=(A &&) = default; > + // PGOGEN: define {{.*}}@_ZN1AaSEOS_ > + // PGOGEN: %pgocount = load {{.*}} @__profc__ZN1AaSEOS_ > + // PGOGEN: {{.*}}add{{.*}}%pgocount, 1 > + // PGOGEN: store{{.*}}@__profc__ZN1AaSEOS_ > + > + // Check that coverage mapping includes 6 function records including the > + // defaulted copy and move operators: A::operator= > + // COVMAP: @__llvm_coverage_mapping = {{.*}} { { i32, i32, i32, i32 }, > [3 x <{{.*}}>], > + B b; > +}; > + > +int main() { > + A a1, a2; > + a1 = a2; > + a2 = static_cast<A &&>(a1); > + return 0; > +} > Index: cfe/trunk/lib/CodeGen/CGClass.cpp > =================================================================== > --- cfe/trunk/lib/CodeGen/CGClass.cpp > +++ cfe/trunk/lib/CodeGen/CGClass.cpp > @@ -1608,6 +1608,7 @@ > > LexicalScope Scope(*this, RootCS->getSourceRange()); > > + incrementProfileCounter(RootCS); > AssignmentMemcpyizer AM(*this, AssignOp, Args); > for (auto *I : RootCS->body()) > AM.emitAssignment(I); > > > > _______________________________________________ > llvm-commits mailing list > llvm-comm...@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
