NoQ marked an inline comment as done. NoQ added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:157 ClusterBindings::Factory *CBFactory; + bool IsMainAnalysis; ---------------- We could have put this flag into `RegionStoreManager` instead - after all, it doesn't change for the whole duration of the analysis. It would have made it easier to handle (avoid weird bitwise logic) and probably cheaper, but it'll make the manager needlessly stateful (which wouldn't really hurt at all right now, just looks ugly). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65361/new/ https://reviews.llvm.org/D65361 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
