SureYeaah added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:299
// return statement
return ^1;
}
----------------
kadircet wrote:
> left out this one ?
Since that's an IntegerLiteral, this patch doesn't apply to it?
================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:302
void f() {
- int a = 5 + [[4 ^* ^xyz^()]];
+ int a = 5 + [[4 * [[xyz()]]]];
// multivariable initialization
----------------
kadircet wrote:
> kadircet wrote:
> > how come these changes part of that patch?
> >
> > is it possible that this tweak was changed to not trigger on empty
> > selections, but tests were not updated? If that's the case could you please
> > send these on a different patch and rebase this patch on that one?
> > how come these changes part of that patch?
>
> how come these changes *are* part of that patch?
>
>
This patch doesn't involve empty selection triggers. Reverted these changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64717/new/
https://reviews.llvm.org/D64717
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
