hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Let's rephrase the commit message, I think this patch is just to "emit the
semantic highlighting tokens when the main AST is built".
================
Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:844
+TEST(ClangdSemanticHighlightingTest, GeneratesHighlightsWhenFileChange) {
+ class HighlightingsCounterDiagConsumer : public DiagnosticsConsumer {
----------------
maybe move this test to SemanticHighlightingTests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63821/new/
https://reviews.llvm.org/D63821
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
