jvikstrom marked an inline comment as done. jvikstrom added inline comments.
================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:60 + void + onHighlightingsReady(PathRef File, + std::vector<HighlightingToken> Highlightings) override; ---------------- hokein wrote: > nit: you can remove this override, since we have provided an empty default > implementation. I get an `-Winconsistent-missing-override` warnings without the override. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63821/new/ https://reviews.llvm.org/D63821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
