astrelni marked an inline comment as done. astrelni added a comment. In D62977#1533384 <https://reviews.llvm.org/D62977#1533384>, @Eugene.Zelenko wrote:
> I think will be good idea to replace //upgrade// with //modernize// to be > consistent with similar checks in other module. I will work on changing this in the next diff update, if your opinion holds. The context for currently using "upgrade" is: a) The modernize module seems to contain checks that are geared at using more modern language features as opposed to API breaking changes. With some exceptions, they seem to be about changing from old to new practice while both ways remain valid code. The goal of this check is to take code that will break with future googletest API changes and turn it into working code, allowing users to upgrade the version of googletest they use. Maybe upgrade is not the best term, but I don't think modernize is a better fit. b) The check is meant to be consistent with abseil-upgrade-duration-conversions, which is aimed to upgrade code before API breaking changes. So if we change this check, I would like to change the Abseil one as well. Maybe this would be better done together in a follow-up patch? I don't feel very strongly, just thought it would be good to provide the context. Please let me know how you'd like me to proceed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62977/new/ https://reviews.llvm.org/D62977 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
