Eugene.Zelenko added a comment.
I think will be good idea to replace //upgrade// with //modernize// to be
consistent with similar checks in other module.
================
Comment at:
clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp:170
+
+llvm::StringRef getNewMethodName(llvm::StringRef CurrentName) {
+ std::pair<llvm::StringRef, llvm::StringRef> ReplacementMap[] = {
----------------
Function should be static instead on placed in anonymous namespace. See LLVM
Coding Guidelines. Same for other places.
================
Comment at: clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.h:13
+#include "../ClangTidyCheck.h"
+
+#include <unordered_set>
----------------
Please remove unnecessary empty line.
================
Comment at:
clang-tools-extra/docs/clang-tidy/checks/google-upgrade-googletest-case.rst:13
+
+The affected APIs are :
+
----------------
Please remove space before colon.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62977/new/
https://reviews.llvm.org/D62977
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
