ilya-biryukov added a comment. In D62514#1518941 <https://reviews.llvm.org/D62514#1518941>, @kadircet wrote:
> thanks, lgtm. > > one irrelevant question though, it looks like most of the calls to > `ResultBuilder::setPreferredType` performs a `!isNull` check before hand. > should we perform this check implicitly and make the `setPreferredType` no-op > in case of a null type? I don't see any reason why not, that could save some typing. Better yet, we might be able to remove it altogether. Preferred type is also stored in completion context and I'm not sure whether it's ever different from the one in `ResultBuilder`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62514/new/ https://reviews.llvm.org/D62514 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
