kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, lgtm. one irrelevant question though, it looks like most of the calls to `ResultBuilder::setPreferredType` performs a `!isNull` check before hand. should we perform this check implicitly and make the `setPreferredType` no-op in case of a null type? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62514/new/ https://reviews.llvm.org/D62514 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits