martong marked an inline comment as done.
martong added inline comments.
================
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:922
+
+ Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST));
+ if (log_ast) {
----------------
shafik wrote:
> I am going to say that the logging change is an excellent additions and
> stands alone from this change. Although I realize the test depends on this
> new feature. It makes sense to add the logging in a separate PR.
>
> I also say this b/c I found a regression and it would be nice to get the
> logging in while we resolve the regression.
Ok, I have created a new patch for logging (https://reviews.llvm.org/D62061).
I made this patch to be the child of that and rebased to that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61333/new/
https://reviews.llvm.org/D61333
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
