shafik added a comment.
I ran `check-lldb` and I hit one regression in `TestFormatters.py`, part of
what I am seeing is as follows:
AssertionError: False is not True : FileCheck'ing result of `expression
--show-types -- *(new foo(47))`
Error output:
error: no matching constructor for initialization of 'foo'
candidate constructor (the implicit copy constructor) not viable: no known
conversion from 'int' to 'const foo' for 1st argument
candidate constructor (the implicit move constructor) not viable: no known
conversion from 'int' to 'foo' for 1st argument
================
Comment at: clang/lib/AST/ASTImporter.cpp:1818
+ // The class will have DefinitionData, but no members. Then,
+ // importDefinition is called from LLDB, which tries to get the members, se
+ // when we get here, the class already has the DefinitionData set, so we must
----------------
se -> so?
================
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:922
+
+ Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST));
+ if (log_ast) {
----------------
I am going to say that the logging change is an excellent additions and stands
alone from this change. Although I realize the test depends on this new
feature. It makes sense to add the logging in a separate PR.
I also say this b/c I found a regression and it would be nice to get the
logging in while we resolve the regression.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61333/new/
https://reviews.llvm.org/D61333
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
