tstellar added inline comments.
================ Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) + set_source_files_properties(LoopPassManagerTest.cpp PROPERTIES COMPILE_FLAGS -Wno-unused-function) +endif() ---------------- aganea wrote: > tstellar wrote: > > aganea wrote: > > > tstellar wrote: > > > > Same thing here too. > > > Not sure I understand, there're plenty of compiler-specific examples in > > > the .cmake files. Is there an alternate way to fix this? > > I know there are some, but I don't think a warning like this is important > > enough to fix with a compiler specific work-around. > You mean more like > ``` > # Workaround for the gcc 6.1 bug > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. > if (NOT MSVC) > set_source_files_properties(LoopPassManagerTest.cpp PROPERTIES > COMPILE_FLAGS -Wno-unused-function) > endif() > ``` > Or leave the warning? There's already an #ifdef below in > LoopPassManagerTest.cpp but it's not at the right place, this simply corrects > it. Ok, I see in this case you are just moving the ifdef out of the code and into CMake. I really don't like either approach, but I guess this is fine. I would limit the work-around to only known broken compilers though. It looks like this might be fixed in gcc 9. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
