richard.townsend.arm added inline comments.
================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1090 + FI.getReturnInfo().setSRetAfterThis(isInstanceMethod); + FI.getReturnInfo().setInReg(isAArch64 && isIndirectReturn); ---------------- Based on https://reviews.llvm.org/D60348 - lib/Target/AArch64/AArch64CallingConvention.td (line 44), should this be (isIndirectReturn || isInstanceMethod)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits