efriedma added inline comments.

================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1062
+  bool sretInX0 = (CGM.getTarget().getTriple().getArch() ==
+                   llvm::Triple::aarch64) && !RD->isPOD();
+
----------------
ostannard wrote:
> This should also check aarch64_be.
aarch64_be-windows isn't a thing; it doesn't make sense to check for that 
explicitly.

That said, there is an isAArch64() helper which is probably more readable 
anyway.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60349/new/

https://reviews.llvm.org/D60349



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to