hintonda marked an inline comment as done. hintonda added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:23 -typedef llvm::SmallSet<llvm::StringRef, 5> HeaderFileExtensionsSet; +typedef SmallSet<StringRef, 5> HeaderFileExtensionsSet; ---------------- hintonda wrote: > Eugene.Zelenko wrote: > > Please use using. See modernize-use-using. > Normally I'd agree, but since the llvm checkers live in the llvm namespace, > including any llvm checker prior to this header will prevent clang from > finding `llvm::SmallSet`. As you can see, the other llvm classes don't need > the `llvm::` prefix, but that's because `clang/include/clang/Basic/LLVM.h` > already has a bunch of `using` statements. > > So, this code won't compile without this change, or the addition of `using > llvm::SmallSet;` to `clang/include/clang/Basic/LLVM.h`. Should I make that > change first? Then just remove the `llvm::` prefix? Oh, sorry, didn't read closely enough. I can get rid of the typedef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
