Eugene.Zelenko added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:23 -typedef llvm::SmallSet<llvm::StringRef, 5> HeaderFileExtensionsSet; +typedef SmallSet<StringRef, 5> HeaderFileExtensionsSet; ---------------- Please use using. See modernize-use-using. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:136 + + Finds cases of cast<> used as condition in conditional statements which will + assert on failure in Debug builds. ---------------- Please enclose cast<> in ``. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-avoid-cast-in-conditional.rst:6 + +Finds cases of cast<> used as the condition of a conditional +statements which will assert on failure in Debug builds. The use of ---------------- Please enclose cast<> in ``. Same below. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-avoid-cast-in-conditional.rst:7 +Finds cases of cast<> used as the condition of a conditional +statements which will assert on failure in Debug builds. The use of +cast<> implies that the operation cannot fail, and should not be used ---------------- Please fix double space. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-avoid-cast-in-conditional.rst:9 +cast<> implies that the operation cannot fail, and should not be used +as the condition of a conditional statement.. + ---------------- Please fix double dot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
