lebedev.ri added a comment. In D56624#1369626 <https://reviews.llvm.org/D56624#1369626>, @yln wrote:
> In D56624#1368966 <https://reviews.llvm.org/D56624#1368966>, @lebedev.ri > wrote: > > > Please revert this. > > First, this wasn't reviewed. > > Second, the lists weren't subscribed. > > > I apologize for this. It was not my intention to land the revision without > formal acceptance. > > commit-lists: > I prepared this patch via the monorepo and did not select a repository in > Phabricator because the changes span multiple repos. I guess rL <https://reviews.llvm.org/diffusion/L/> would be a safe default to make. > This means that I have to manually ensure that the correct lists are > subscribed in the Phabricator web interface, correct? Looks like the rules to subscribe the lists based on a content of the patch are still not added, so i'd say yes. That being said, the normal practice in such situations is to open a new review. Also, i suspect this should be split up into **at least** two parts - the new LLVM IR `expect_noreturn` attribute, and the rest. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56624/new/ https://reviews.llvm.org/D56624 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
