lebedev.ri added inline comments.
================
Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35
+ std::vector<std::string> FunctionsThatShouldNotThrowVec =
+ utils::options::parseStringList(RawFunctionsThatShouldNotThrow);
FunctionsThatShouldNotThrow.insert(FunctionsThatShouldNotThrowVec.begin(),
----------------
Does it also accept ',' delimitter?
If not, i'm not sure how good of an idea it is to break existing configs..
================
Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:1
+#include "ExceptionAnalyzer.h"
+
----------------
Standard licence blurb missing.
================
Comment at: test/clang-tidy/bugprone-exception-escape.cpp:1
-// RUN: %check_clang_tidy %s bugprone-exception-escape %t --
-extra-arg=-std=c++11 -extra-arg=-fexceptions -config="{CheckOptions: [{key:
bugprone-exception-escape.IgnoredExceptions, value: 'ignored1,ignored2'}, {key:
bugprone-exception-escape.FunctionsThatShouldNotThrow, value:
'enabled1,enabled2,enabled3'}]}" --
+// RUN: %check_clang_tidy %s bugprone-exception-escape %t --
-extra-arg=-std=c++11 -extra-arg=-fexceptions -config="{CheckOptions: [{key:
bugprone-exception-escape.IgnoredExceptions, value: 'ignored1;ignored2'}, {key:
bugprone-exception-escape.FunctionsThatShouldNotThrow, value:
'enabled1;enabled2;enabled3'}]}" --
----------------
Hm, this may be a breaking change, and the check existed in 7.0 already.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57100/new/
https://reviews.llvm.org/D57100
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
