baloghadamsoftware added a comment. Hello! I am glad to see that this check gets improved by the community. I also think a "modernize" check which marks functions with `noexcept` is also useful.
As for the comma or semicolon, I think semicolon would be better. I see that this part is reverted now, but is there any reason for using `std::string` instead of `llvm::StringRef`? I always thought this latter is the standard for LLVM code wherever possible. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/ https://reviews.llvm.org/D57100 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
