aaron.ballman added a comment. In D56967#1365742 <https://reviews.llvm.org/D56967#1365742>, @aaronpuchert wrote:
> Thanks for the review! I'll commit this when I have commit access again, > which is waiting for my employer's approval to the relicensing. Sounds good to me! ================ Comment at: lib/Sema/AnalysisBasedWarnings.cpp:1693 + << Kind << LockName); + OptionalNotes notes = + LocLocked.isValid() ---------------- aaronpuchert wrote: > I'll assume it's also `Notes` then. I tend to subconsciously forget these > things. Yup, my eyes missed that one, so thank you for catching it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56967/new/ https://reviews.llvm.org/D56967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits