aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a naming convention nit. ================ Comment at: lib/Analysis/ThreadSafety.cpp:984 StringRef DiagKind) const { - if (!FSet.findLock(FactMan, Cp)) { + if (const FactEntry *fact = FSet.findLock(FactMan, Cp)) { + if (Handler) ---------------- fact -> Fact Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56967/new/ https://reviews.llvm.org/D56967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits