alexfh added inline comments.

================
Comment at: clang-tidy/misc/MiscTidyModule.cpp:58
@@ -57,3 +56,1 @@
-    CheckFactories.registerCheck<InefficientAlgorithmCheck>(
-        "misc-inefficient-algorithm");
     CheckFactories.registerCheck<MacroParenthesesCheck>(
----------------
alexfh wrote:
> aaron.ballman wrote:
> > This will break projects that enable the misc-inefficient-algorithm check 
> > (which clang 3.7 exposed). Is there a reason to not keep this check 
> > registered under this name?
> > 
> > (Perhaps a follow-up patch to allow deprecation of check names so that 
> > users are given guidance would make sense.)
> I don't feel strongly, but I'm somewhat reluctant to keep old check names. 
> With every new clang-tidy version someone starts using on a project, they 
> need to carefully look at the list of checks and select relevant ones anyway. 
> I think, adding facilities for deprecating checks and keeping old names is 
> not going to help much, but will certainly add support burden for us.
But we certainly need to mention the rename in the release notes for 3.8.


http://reviews.llvm.org/D16248



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to