I'll take a look at the regression, thanks. As noted in the other review thread, the new unit test you linked is broken: the code snippet doesn't compile (a&&), which seems to be the cause of the crash, or at least masks it.
On Tue, Jan 8, 2019, 23:20 Jonas Toth via Phabricator < revi...@reviews.llvm.org wrote: > JonasToth added a comment. > > I still see the unit-test crashing for `ExprMutAnalyzer` (just apply these > tests > https://github.com/JonasToth/clang/blob/fix_crash/unittests/Analysis/ExprMutationAnalyzerTest.cpp > and run `check-clang-unit`) > The clang-tidy check does not crash anymore, but > `readability-function-size` regresses. It probably doesn't properly count > for lambdas anymore. > > > Repository: > rC Clang > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D56444/new/ > > https://reviews.llvm.org/D56444 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
