aaron.ballman added inline comments.
================
Comment at: clang-query/QueryParser.cpp:33
+ if (Line.empty())
+ return StringRef(Line.begin(), 0);
----------------
steveire wrote:
> aaron.ballman wrote:
> > Why not just return `Line`?
> It is the pre-existing behavior to return a zero-length StringRef with a
> valid Begin pointer in this case. I think the reason is something to do with
> code completion. I can check later.
I believe returning `Line` is identical -- you should wind up with the same
"begin" pointer for the returned string and a length of zero (because `Line`
must be empty by this point).
================
Comment at: clang-query/QueryParser.cpp:37
+ Line = {};
return StringRef();
}
----------------
steveire wrote:
> aaron.ballman wrote:
> > Why not just return `Line` here as well?
> That's pre-existing. Seems more clear to leave it as is.
I don't have a strong preference, but I raised the point because it seems odd
to explicitly clear a `StringRef` and then return a new, different, empty
`StringRef` on the next line.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56415/new/
https://reviews.llvm.org/D56415
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
