kristina added a reviewer: kristina.
kristina added a comment.
LGTM aside from one comment.
================
Comment at: clang-query/QueryParser.cpp:36
+ if (Line.front() == '#') {
+ Line = {};
return StringRef();
----------------
I don't think this is the best way of handling it, in fact I'm pretty certain
you're leaking memory here.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56415/new/
https://reviews.llvm.org/D56415
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
